[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kchart/shape
From:       Johannes Simon <johannes.simon () gmail ! com>
Date:       2010-05-24 15:54:40
Message-ID: 20100524155440.AF929AC8BE () svn ! kde ! org
[Download RAW message or body]

SVN commit 1130151 by jsimon:

Followup of commit 1128831 by rempt:

Fix safety-check. I think you confused the "<=" with a ">=".

CCMAIL:boud@valdyas.org

 M  +1 -3      KDChartModel.cpp  


--- trunk/koffice/kchart/shape/KDChartModel.cpp #1130150:1130151
@@ -366,13 +366,11 @@
     if ( orientation != d->dataDirection ) {
         int dataSetNumber = section / d->dataDimensions;
 
-        if (d->dataSets.count() >= dataSetNumber) {
+        if ( d->dataSets.count() <= dataSetNumber ) {
             qWarning() << "KDChartModel::headerData(): trying to get more datasets than we have.";
             return QVariant();
         }
 
-        Q_ASSERT( dataSetNumber < d->dataSets.count() );
-        qDebug() << dataSetNumber << section << d->dataDimensions;
         DataSet *dataSet  = d->dataSets[ dataSetNumber ];
 
         switch ( role ) {
[prev in list] [next in list] [prev in thread] [next in thread]