[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kchart/shape
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2010-05-20 12:47:05
Message-ID: 20100520124705.0459EAC8BC () svn ! kde ! org
[Download RAW message or body]

SVN commit 1128831 by rempt:

Fix crash bug with stock charts

CCMAIL: johannes.simon@gmail.com
BUG: 231739

Reviewed by Inge Wallin.

 M  +7 -0      KDChartModel.cpp  


--- trunk/koffice/kchart/shape/KDChartModel.cpp #1128830:1128831
@@ -365,7 +365,14 @@
 
     if ( orientation != d->dataDirection ) {
         int dataSetNumber = section / d->dataDimensions;
+
+        if (d->dataSets.count() >= dataSetNumber) {
+            qWarning() << "KDChartModel::headerData(): trying to get more datasets than we have.";
+            return QVariant();
+        }
+
         Q_ASSERT( dataSetNumber < d->dataSets.count() );
+        qDebug() << dataSetNumber << section << d->dataDimensions;
         DataSet *dataSet  = d->dataSets[ dataSetNumber ];
 
         switch ( role ) {
[prev in list] [next in list] [prev in thread] [next in thread]