[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kdeui/icons
From:       Michael Pyne <mpyne () kde ! org>
Date:       2010-05-21 23:11:37
Message-ID: 201005211911.42788.mpyne () kde ! org
[Download RAW message or body]


On Friday, May 21, 2010 05:09:42 David Faure wrote:
> On Friday 21 May 2010, Michael Pyne wrote:
> > SVN commit 1129007 by mpyne:
> > 
> > Cache when KIconLoader::loadIcon misses finding an icon.
> > 
> > My initial port of KIconLoader to KSharedDataCache didn't include the old
> > behavior of caching icon search misses. Searching for an icon and not
> > finding it is slow! So, cache the results.
> > 
> > I couldn't really understand what loadIcon was supposed to be doing so I
> > spent some time refactoring it instead. The behavior should be compatible
> > with sane usage patterns, but my first attempt didn't size "User" icons
> > appropriately so look at this patch with trepidation if your icons don't
> > work.
> 
> Talking about trepidation... why do I bother writing unittests if people
> who refactor code don't even run them?

:-/

Perhaps ironically I had actually run the unit tests for KIconLoader... but 
not after I had made a change just before my commit to fix a problem with the 
size of Unit icons.

I'll either fix the code tonight or revert and fix using a different method.

Regards,
 - Michael Pyne

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]