From kde-commits  Fri May 21 23:11:37 2010
From: Michael Pyne <mpyne () kde ! org>
Date: Fri, 21 May 2010 23:11:37 +0000
To: kde-commits
Subject: Re: KDE/kdelibs/kdeui/icons
Message-Id: <201005211911.42788.mpyne () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-commits&m=127448356104335
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1462772.hAQzqJLba1"

--nextPart1462772.hAQzqJLba1
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Friday, May 21, 2010 05:09:42 David Faure wrote:
> On Friday 21 May 2010, Michael Pyne wrote:
> > SVN commit 1129007 by mpyne:
> >=20
> > Cache when KIconLoader::loadIcon misses finding an icon.
> >=20
> > My initial port of KIconLoader to KSharedDataCache didn't include the o=
ld
> > behavior of caching icon search misses. Searching for an icon and not
> > finding it is slow! So, cache the results.
> >=20
> > I couldn't really understand what loadIcon was supposed to be doing so I
> > spent some time refactoring it instead. The behavior should be compatib=
le
> > with sane usage patterns, but my first attempt didn't size "User" icons
> > appropriately so look at this patch with trepidation if your icons don't
> > work.
>=20
> Talking about trepidation... why do I bother writing unittests if people
> who refactor code don't even run them?

:-/

Perhaps ironically I had actually run the unit tests for KIconLoader... but=
=20
not after I had made a change just before my commit to fix a problem with t=
he=20
size of Unit icons.

I'll either fix the code tonight or revert and fix using a different method.

Regards,
 - Michael Pyne

--nextPart1462772.hAQzqJLba1
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iQIcBAABCAAGBQJL9xMuAAoJEAuvDJx7aunyfsoQAJd21AUNaK0B3IrZMDQ9Zyhn
moalaBvAokRahFGY0mkg5e8rfJeoKn+tNNdCNqohScS27xi8G1PoWESImji3E0qO
w6vx0zEjP+2WW2SY9ZcqAxaTamkqhN5hYu0bY9Q4FMHFbc3F9iRz2dyxfVL4bvs7
zK/zTziLGuGf/bu5LOfbL3bnCj5PcsNLT2T3tE1BVCHOf12Pb427E3pUDz5z1n00
RBeP76WefvhV1XW5FSRapFTqQcQPKPJnSm2G1SPWmand8D4v0j0x5Ok4ltAIObCm
pc1k+LOK/4wUMa560lubPAPLeMvSUS4BW+arzi4sbHePjDKVnDV79z+pucO7hyNN
WTApS/LwbFNiqIB6l1hywJ7Hs0gc9TuX6lFagVfmXBCw3I4Qsx/4dVZf3YlW3ut+
aqFGDXNUyT6DLU1LBFWoiYZcy0x/rHGL37M93Pie138Ecp6rtzpAkdK4NmNlhwaZ
sRvtG35IcBot0gokT8qyWeGJSfxWliFFqCXik4tyw2cWh3TScX2nAEw8G+ap5HY8
P1LkWdmgAvllDM7b2BbPK/p7qCg2HDEO+kORfObzErkJbm2e/cIavz5u3iEc6aOX
rC37RZixIpgojeERZnXgbbSriBijaoZC1t+7OyK+fUREktLJRKLqgntVz5Fwglrv
7Jdfq0nrJj3nwv52k7/P
=I6gA
-----END PGP SIGNATURE-----

--nextPart1462772.hAQzqJLba1--