[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/kdepim/enterprise4/kdepim/libkleo
From:       Marc Mutz <mutz () kde ! org>
Date:       2010-04-24 7:16:42
Message-ID: 20100424071642.5BCEAAC8A7 () svn ! kde ! org
[Download RAW message or body]

SVN commit 1118267 by mutz:

libkleopatrarc: make argument passing more robust for Archive and Checksum Definitions

This requires GNU-compatible tools (for -- and tar --null), and a POSIX system (for xargs),
so it won't work on Windows out of the box (it never did, anyway, unless you had the tools
in PATH). ZIP cannot be called safely, since it accepts options after positional parameters,
doesn't support --, and can accept filenames on stdin only in a newline-separated way (which
breaks when filenames contain newlines).

We might need a way to specify which platform a given Archive Definition / Checksum Definition
is compatible with...

 M  +4 -4      libkleopatrarc.desktop  


--- branches/kdepim/enterprise4/kdepim/libkleo/libkleopatrarc.desktop #1118266:1118267
@@ -3,7 +3,7 @@
 id=tar
 Name=TAR (PGP ®-compatible)
 Name[de]=TAR (PGP ®-kompatibel)
-pack-command=tar cf -
+pack-command=0|tar cf - -T- --null
 
 [Archive Definition #1]
 extensions=zip
@@ -17,14 +17,14 @@
 id=bzip2
 Name=TAR (with bzip2 compression)
 Name[de]=TAR (mit bzip2-Kompression)
-pack-command=tar cfj -
+pack-command=0|tar cfj - -T- --null
 
 [Checksum Definition #1]
 file-patterns=sha1sum.txt
 output-file=sha1sum.txt
 id=sha1sum
 Name=sha1sum
-create-command=sha1sum -- %f
+create-command=0|xargs -0 sha1sum --
 verify-command=sha1sum -c --
 
 [Checksum Definition #2]
@@ -32,7 +32,7 @@
 output-file=md5sum.txt
 id=md5sum
 Name=md5sum
-create-command=md5sum -- %f
+create-command=0|xargs -0 md5sum --
 verify-command=md5sum -c --
 
 [Key Filter #0]
[prev in list] [next in list] [prev in thread] [next in thread]