[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/plugins/pathshapes/enhancedpath
From:       jaham () gmx ! net
Date:       2010-03-14 12:21:31
Message-ID: 201003141321.32270.jaham () gmx ! net
[Download RAW message or body]

On Sunday 14 March 2010 01:32:20 Carlos Licea wrote:
> On Saturday 13 March 2010 15:39:53 Jan Hambrecht escribió:
> >SVN commit 1102906 by jaham:
> >
> >fix loading/saving of size dependent of viewbox
> >
> > M  +12 -1     EnhancedPathShape.cpp
> >
> >--- trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
> >#1102905:1102906 @@ -328,8 +328,15 @@
> >
> > {
> > 
> >     if (isParametricShape()) {
> >     
> >         context.xmlWriter().startElement("draw:custom-shape");
> >
> >-        saveOdfAttributes(context, OdfAllAttributes);
> >+        saveOdfAttributes(context, OdfAllAttributes|~OdfSize);
> 
> Note that OdfAllAttributes|~OdfSize doesn't remove OdfSize from
> OdfAllAttributes, it would just activate all the bits except for OdfSize,
> but all the bits are activated, so no change in behavior.
> If you want to remove the OdfSize flag from OdfAllAttributes the right way
> is doing a XOR:
> 	OdfAllAttributes ^ OdfSize
> 
> (Note that if OdfSize wasn't set, it would set it because of the XOR
> behavior, but since all the bits are set it does remove it).

Indeed, my intention was more like OdfAllAttributes &~OdfSize which would mask 
out the OdfSize bits from the bit mask.

Thanks for the heads up, will change that in a minute.

Ciao Jan

[prev in list] [next in list] [prev in thread] [next in thread]