[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/plugins/pathshapes/enhancedpath
From:       Carlos Licea <carlos_licea () hotmail ! com>
Date:       2010-03-14 0:32:20
Message-ID: BLU0-SMTP879C801DC8245A6DE31761F22F0 () phx ! gbl
[Download RAW message or body]

On Saturday 13 March 2010 15:39:53 Jan Hambrecht escribió:
>SVN commit 1102906 by jaham:
>
>fix loading/saving of size dependent of viewbox
>
>
>
> M  +12 -1     EnhancedPathShape.cpp
>
>
>--- trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
>#1102905:1102906 @@ -328,8 +328,15 @@
> {
>     if (isParametricShape()) {
>         context.xmlWriter().startElement("draw:custom-shape");
>-        saveOdfAttributes(context, OdfAllAttributes);
>+        saveOdfAttributes(context, OdfAllAttributes|~OdfSize);
Note that OdfAllAttributes|~OdfSize doesn't remove OdfSize from 
OdfAllAttributes, it would just activate all the bits except for OdfSize, but 
all the bits are activated, so no change in behavior.
If you want to remove the OdfSize flag from OdfAllAttributes the right way is 
doing a XOR:
	OdfAllAttributes ^ OdfSize

(Note that if OdfSize wasn't set, it would set it because of the XOR 
behavior, but since all the bits are set it does remove it).

Carlos Licea

[prev in list] [next in list] [prev in thread] [next in thread]