[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: KDE/kdeplasma-addons/applets/weather
From: "Artur de Souza \(MoRpHeUz\)" <asouza () kde ! org>
Date: 2010-03-09 21:29:25
Message-ID: 1268170165.2007.5.camel () Nokia-N900-51-1
[Download RAW message or body]
----- Original message -----
> thing is: that hardcoded size will still break with large enough fonts (and
> probably in other ways). it really isn't a fix, and as such i don't think it
> should be in svn at all.
Large fonts break the current code too and bigger content too. The layout is broken \
(even the icon is hard coded to position 0,0 - try resizing the applet and you will \
see the icon being misplaced).
I will revert the commit tonight and reopen the bug anyway. But if this is not a \
workaround that should be in svn at all, neither should the other patches that have \
been commited in the past for this applet (I looked at them before commiting this \
one).
Cheers,
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" \
"http://www.w3.org/TR/html4/loose.dtd"> <html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="generator" content="Osso Notes">
<title></title></head>
<body>
<p>----- Original message -----
<br>> thing is: that hardcoded size will still break with large enough fonts (and
<br>> probably in other ways). it really isn't a fix, and as such i don't think it
<br>> should be in svn at all.
<br>
<br>Large fonts break the current code too and bigger content too. The layout is \
broken (even the icon is hard coded to position 0,0 - try resizing the applet and you \
will see the icon being misplaced). <br>
<br>I will revert the commit tonight and reopen the bug anyway. But if this is not a \
workaround that should be in svn at all, neither should the other patches that have \
been commited in the past for this applet (I looked at them before commiting this \
one). <br>
<br>Cheers,<br></p>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic