[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdeplasma-addons/applets/weather
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-03-09 17:58:36
Message-ID: 201003090958.37076.aseigo () kde ! org
[Download RAW message or body]

On March 9, 2010, Artur Souza (MoRpHeUz) wrote:
> On Tuesday 09 March 2010, 13:22 Aaron J. Seigo wrote:
> > setting a hardcoded size doesn't look right; shouldn't it get this
> > information from the size hint of the widget?
> 
> Actually there is a lot of layout problems with this applet, and the proper
> solution is to redo all the layout code (most of the applet unfortunately
> :( ).
> 
> I agree that the hardcoded size doesn't look right, it was just the easier
> way to fix the ugly behavior it had before (it was a shame when demoing
> plasma and resize of plasmoids and it got all the widgets outside the
> applet's border =/).
> 
> Can we let this way (hardcoded) until someone that is brave enough step up
> and fix the layout issues ?

thing is: that hardcoded size will still break with large enough fonts (and 
probably in other ways). it really isn't a fix, and as such i don't think it 
should be in svn at all.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
[prev in list] [next in list] [prev in thread] [next in thread]