[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/kdepim/enterprise4/kdelibs-4.1-branch/kdeui/dialogs
From:       Thomas McGuire <mcguire () kde ! org>
Date:       2009-10-11 17:20:25
Message-ID: 200910111920.30784.mcguire () kde ! org
[Download RAW message or body]


Hi,

On Sunday 11 October 2009 16:02:16 Marc Mutz wrote:
> On Friday October 9 2009, Thomas McGuire wrote:
> > Hi Marc,
> >
> > On Wednesday 07 October 2009 11:41:47 Marc Mutz wrote:
> > > SVN commit 1032206 by mutz:
> > >
> > > KAboutApplicationDialog: add options to suppress translators tab and
> > > kde version.
> > >
> > > This allows to use this dialog for other About Foo dialogs than just
> > > the one for the application, as seen in the About Gpg4win dialog in
> > > Kleopatra.
> > >
> > >  M  +35 -15    kaboutapplicationdialog.cpp
> > >  M  +22 -1     kaboutapplicationdialog.h
> > >
> > > [SNIP]
> > >
> > >      }
> > > +    }
> >
> > Can you please indent those if statements correctly? That makes the code
> > more readable and less confusing.
> > I've seen this in 3 places now.
> 
> I'm doing this in a futile attempt to preserve what little history there is
> left in SVN after all the whitespace-only changes :)

I'd greatly prefer a messed up history to a messed up code. You can always 
change the whitespace in a second commit, and then svn blame supports ignoring 
whitespace changes.
I'm also waiting for git :)

> > Also, the API documentation for the new stuff here is missing, I'll add
> > that in the merge to kdelibs trunk.
> 
> <snip>
> 
> Indeed, thanks for the reminder. I'll do that first thing on Monday, unless
> you beat me to it.

I've already done it, but only in trunk (but that should be enough).

Regards,
Thomas

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]