[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/kdepim/enterprise4/kdelibs-4.1-branch/kdeui/dialogs
From:       Marc Mutz <marc () kdab ! net>
Date:       2009-10-11 14:02:16
Message-ID: 200910111602.16689.marc () kdab ! net
[Download RAW message or body]

On Friday October 9 2009, Thomas McGuire wrote:
> Hi Marc,
>
> On Wednesday 07 October 2009 11:41:47 Marc Mutz wrote:
> > SVN commit 1032206 by mutz:
> >
> > KAboutApplicationDialog: add options to suppress translators tab and kde
> >  version.
> >
> > This allows to use this dialog for other About Foo dialogs than just the
> >  one for the application, as seen in the About Gpg4win dialog in
> > Kleopatra.
> >
> >  M  +35 -15    kaboutapplicationdialog.cpp
> >  M  +22 -1     kaboutapplicationdialog.h
> >
> > [SNIP]
> >
> >      }
> > +    }
>
> Can you please indent those if statements correctly? That makes the code
> more readable and less confusing.
> I've seen this in 3 places now.

I'm doing this in a futile attempt to preserve what little history there is 
left in SVN after all the whitespace-only changes :)

> Also, the API documentation for the new stuff here is missing, I'll add
> that in the merge to kdelibs trunk.
<snip>

Indeed, thanks for the reminder. I'll do that first thing on Monday, unless 
you beat me to it.

Thanks,
Marc

-- 
Marc Mutz <marc@kdab.com> | Senior Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
[prev in list] [next in list] [prev in thread] [next in thread]