[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevelop/projectmanagers/cmake/parser
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-09-30 21:28:58
Message-ID: 20090930212858.GE6058 () trinity ! apaku ! dnsalias ! org
[Download RAW message or body]

On 30.09.09 20:26:00, Aleix Pol Gonzalez wrote:
> SVN commit 1029826 by apol:
> 
> Fix last commit.
> - Do not use QDir::separator, it's just wrong, Qt deals with it.

Ah, sorry too much java done lately :)

> - Adapt to the current infrastructure.

Thats the part about suffixes/pathSuffixes right? If so its wrong.
pathSuffixes are appended to the current location. So if you have

find_path( foo.h
    PATH_SUFFIXES bar )

CMake searches for
<prefix>/include/foo.h
<prefix>/include/bar/foo.h

So you can't just add "include" to suffixes here. You really have to
iterate over the XXX_PREFIX_PATH variables and for each one add
<prefix>/include to the locationOptions.

Also with this change you'd find a 

<Framework-path>/include/foo.h

which CMake wouldn't find as it only searches for 

<Framework-path>/foo.h

I've had a short look today at the CMake code that does all this and
its a bit complicated to read because of many 'forwarding' calls of
addXXX functions, but most of this is in cmFindCommon.cxx and
cmFindBase.cxx. And the cmake manual also seems to be pretty complete
about what paths are searched for.

Andreas

-- 
You have a deep interest in all that is artistic.
[prev in list] [next in list] [prev in thread] [next in thread]