[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/plasma/applets/folderview
From:       Chani <chanika () gmail ! com>
Date:       2009-08-30 19:59:45
Message-ID: 200908301259.52253.chanika () gmail ! com
[Download RAW message or body]


On August 29, 2009 10:19:33 Fredrik Höglund wrote:
> On Saturday 29 August 2009, Chani Armitage wrote:
> > SVN commit 1017008 by chani:
> >
> > don't mess with mouse events, that's the ContainmentActions'
> > responsibility now.
> >
> >
> >  M  +0 -30     folderview.cpp
> >  M  +0 -2      folderview.h
> >
> >
> > --- trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
> > #1017007:1017008 @@ -1130,27 +1130,6 @@
> >                                     screenRect.bottom() -
> > availRect.bottom()); }
> >
> > -void FolderView::mousePressEvent(QGraphicsSceneMouseEvent *event)
> > -{
> > -    if (isContainment()) {
> > -        if (event->widget()->window()->inherits("DashboardView")) {
> > -            emit releaseVisualFocus();
> > -        }
> 
> Without this code snippet you can't close the dashboard by clicking
> on the containment.

that was intentional? I thought it was a bug...
also, it's happening on *any* click, not just left-click. and returning even 
if there is no dashboard. which means Containmment never ever ever gets any 
mousepressevent and that's not cool.

> 
> Also with the KWindowListMenu code removed there's no need to
> keep the pointer to it, or the libkworkspace dependency.

right, missed that.

right now I'm trying to figure out why it eats all the rightclicks even if it 
doesn't do anything with them...

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]