--nextPart2200934.XEHtZ8ZsQG Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On August 29, 2009 10:19:33 Fredrik H=C3=B6glund wrote: > On Saturday 29 August 2009, Chani Armitage wrote: > > SVN commit 1017008 by chani: > > > > don't mess with mouse events, that's the ContainmentActions' > > responsibility now. > > > > > > M +0 -30 folderview.cpp > > M +0 -2 folderview.h > > > > > > --- trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp > > #1017007:1017008 @@ -1130,27 +1130,6 @@ > > screenRect.bottom() - > > availRect.bottom()); } > > > > -void FolderView::mousePressEvent(QGraphicsSceneMouseEvent *event) > > -{ > > - if (isContainment()) { > > - if (event->widget()->window()->inherits("DashboardView")) { > > - emit releaseVisualFocus(); > > - } >=20 > Without this code snippet you can't close the dashboard by clicking > on the containment. that was intentional? I thought it was a bug... also, it's happening on *any* click, not just left-click. and returning eve= n=20 if there is no dashboard. which means Containmment never ever ever gets any= =20 mousepressevent and that's not cool. >=20 > Also with the KWindowListMenu code removed there's no need to > keep the pointer to it, or the libkworkspace dependency. right, missed that. right now I'm trying to figure out why it eats all the rightclicks even if = it=20 doesn't do anything with them... =2D-=20 This message brought to you by eevil bananas and the number 3. www.chani3.com --nextPart2200934.XEHtZ8ZsQG Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkqa2jIACgkQeGbAwpIS3GxF6wCcCUvvSwGHL3EdMQKsgV81TOzd 4RIAoLiY3fYdJRfvFFlmBG84ya4jfQfl =pTen -----END PGP SIGNATURE----- --nextPart2200934.XEHtZ8ZsQG--