[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: branches/work/akonadi-ports/kdepim/korganizer
From:       Sebastian Sauer <sebsauer () kdab ! net>
Date:       2009-06-30 23:10:18
Message-ID: 20090630230905.EA19DE6C74E () smykowski ! kdab ! net
[Download RAW message or body]

Marc Mutz wrote:
> On Tuesday June 30 2009, Sebastian Sauer wrote:
>> -    mCalendar->removeCollection( collection );
>> +    if( mCalendar->hasCollection( collection ) )
>> +      mCalendar->removeCollection( collection );
> 
> That should be fixed in removeCollection(). Requiring every caller of
> removeCollection() to do a check is bad API design.

Nope, it's perfect for now.

> Someone will forget to call this sooner or later.

There is no later cause it's work in progress. We plan here to remove the 
global collectionview-hack and add a per-view hack :-)


[prev in list] [next in list] [prev in thread] [next in thread]