From kde-commits  Tue Jun 30 23:10:18 2009
From: Sebastian Sauer <sebsauer () kdab ! net>
Date: Tue, 30 Jun 2009 23:10:18 +0000
To: kde-commits
Subject: Re: branches/work/akonadi-ports/kdepim/korganizer
Message-Id: <20090630230905.EA19DE6C74E () smykowski ! kdab ! net>
X-MARC-Message: https://marc.info/?l=kde-commits&m=124653891819671

Marc Mutz wrote:
> On Tuesday June 30 2009, Sebastian Sauer wrote:
>> -    mCalendar->removeCollection( collection );
>> +    if( mCalendar->hasCollection( collection ) )
>> +      mCalendar->removeCollection( collection );
> 
> That should be fixed in removeCollection(). Requiring every caller of
> removeCollection() to do a check is bad API design.

Nope, it's perfect for now.

> Someone will forget to call this sooner or later.

There is no later cause it's work in progress. We plan here to remove the 
global collectionview-hack and add a per-view hack :-)