[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/guiutils
From:       Thomas Zander <zander () kde ! org>
Date:       2009-04-17 5:48:56
Message-ID: 200904170748.57207.zander () kde ! org
[Download RAW message or body]

On Thursday 16 April 2009 09:26:23 Boudewijn Rempt wrote:
> On Wednesday 15 April 2009, Thomas Zander wrote:
>
> I'm not sure whether mere cleanups warrant a copyright addition,

why would my new code not warrent this?

> but more importantly:
> > -class KOGUIUTILS_EXPORT KoUniColorDialog
> > -     : public KPageDialog
> > +class KOGUIUTILS_EXPORT KoUniColorDialog : public KPageDialog
>
> this change really hurts readability and editability. If our coding
> standards really insist on this layout (cite?) I think they should be
> changed asap.

Having it on one lines less than 80 char wide is indeed the way it is done in 
Qt, KDELibs, most of KDE and KOffice libs.

Readability is most of the time recognizability, so consistency helps a lot.
[prev in list] [next in list] [prev in thread] [next in thread]