[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/guiutils
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2009-04-16 7:26:23
Message-ID: 200904160926.23746.boud () valdyas ! org
[Download RAW message or body]

On Wednesday 15 April 2009, Thomas Zander wrote:

I'm not sure whether mere cleanups warrant a copyright addition,
but more importantly:

> -class KOGUIUTILS_EXPORT KoUniColorDialog
> -     : public KPageDialog
> +class KOGUIUTILS_EXPORT KoUniColorDialog : public KPageDialog

this change really hurts readability and editability. If our coding standards 
really insist on this layout (cite?) I think they should be changed asap.

-- 
Boudewijn Rempt | http://www.valdyas.org
[prev in list] [next in list] [prev in thread] [next in thread]