[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/guiutils
From:       Thomas Zander <zander () kde ! org>
Date:       2009-03-30 18:42:35
Message-ID: 200903302042.43476.zander () kde ! org
[Download RAW message or body]


On Monday 30. March 2009 20.26.31 Cyrille Berger wrote:
> SVN commit 947009 by berger:
>
> "Fix:" random crash when drawing on a layer with an effect mask
>
>  M  +0 -1      KoProgressBar.cpp
>  M  +11 -1     KoProgressUpdater.cpp
>
[]
>
>  void KoProgressUpdater::scheduleUpdate() {
> -    d->action->execute();
> +//     d->action->execute();
> +
> +    // The previous line triggers random crashes, that are impossible to
> track or to trully understand, +    // to fix that issue, I make directly
> the following call, I believe this is a wrong change, since it +    //
> probably have a significant performance impact (especially on small
> operation) and +    // that a simple QThread running would be better, but
> for now this change will have to do. +    //HACK
> +    d->update();
> +    d->updateUi();
> +    // ENDHACK
> +

I can understand your need to fix a bug, but this is rather extreme since you 
throw away the whole concept of KoAction by executing the action and the 
updating in the same thread.

I think this introduces more problems that it solves :(

Have you checked that the usage of the updater is the same as in the unit 
tests or the print dialog?  I have run them hundreds of times and never got 
random crashes.

Please also test if printing of a multi page doc in kword still works.


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]