[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/libs/guiutils
From:       Cyrille Berger <cyb () lepi ! org>
Date:       2009-03-30 18:26:31
Message-ID: 1238437591.635664.27787.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 947009 by berger:

"Fix:" random crash when drawing on a layer with an effect mask

 M  +0 -1      KoProgressBar.cpp  
 M  +11 -1     KoProgressUpdater.cpp  


--- trunk/koffice/libs/guiutils/KoProgressBar.cpp #947008:947009
@@ -37,7 +37,6 @@
 
 void KoProgressBar::setValue( int value )
 {
-    QApplication::processEvents(QEventLoop::ExcludeUserInputEvents);
     if( value >= minimum() && value < maximum() )
     {
         QProgressBar::setValue( value );
--- trunk/koffice/libs/guiutils/KoProgressUpdater.cpp #947008:947009
@@ -149,7 +149,17 @@
 }
 
 void KoProgressUpdater::scheduleUpdate() {
-    d->action->execute();
+//     d->action->execute();
+
+    // The previous line triggers random crashes, that are impossible to track or to \
trully understand, +    // to fix that issue, I make directly the following call, I \
believe this is a wrong change, since it +    // probably have a significant \
performance impact (especially on small operation) and +    // that a simple QThread \
running would be better, but for now this change will have to do. +    //HACK
+    d->update();
+    d->updateUi();
+    // ENDHACK
+    
     QApplication::processEvents(QEventLoop::ExcludeUserInputEvents); // This is \
needed otherwise the action doesn't emit its signal (sick) TODO: it would probably \
better to do without the signal emiting things of KoAction and to connect directly \
threadweaver stuff to the updates functions  }
 


[prev in list] [next in list] [prev in thread] [next in thread]