[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps
From:       Jakob Petsovits <jpetso () gmx ! at>
Date:       2009-01-23 11:58:36
Message-ID: 200901231258.37540.jpetso () gmx ! at
[Download RAW message or body]

On Friday 23 January 2009, Lubos Lunak wrote:
> On Monday 19 of January 2009, Jakob Petsovits wrote:
> > SVN commit 913253 by jpetso:
> >
> > Make kdialog use Plasma's notification bling (via D-Bus) if possible,
> > keeping KPassivePopup as fallback in case the D-Bus invocation fails.
> > The invocation code is a heavily simplified version of dimsuz's code
> > in NotifyByPopup of KNotify, therefore his copyright instead of mine.
>
> [about 50 lines of code removed]
>
> + KNotification::event( "kdialogPassivePopup", text );
>
>  Or something like that. Plus the small .eventsrc file. I think it will
> never cease to amaze to me how great lengths some people can go instead of
> doing things simply. Not to count the code duplication or smaller
> flexibility.

I could not find a way to pass the "--title" option to KNotification. Also, when 
using KNotification, I would have to track the widget by myself in order to 
have custom-length timeouts, and that makes for a similar amount of just as 
complicated code.

I had a serious look at KNotification, and it seems to me that the direct
D-Bus invocation is easier and more capable than getting KNotification
to fit kdialog's requirements.

Wishes,
  Jakob

[prev in list] [next in list] [prev in thread] [next in thread]