[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2009-01-23 9:44:32
Message-ID: 200901231044.32391.l.lunak () suse ! cz
[Download RAW message or body]

On Monday 19 of January 2009, Jakob Petsovits wrote:
> SVN commit 913253 by jpetso:
>
> Make kdialog use Plasma's notification bling (via D-Bus) if possible,
> keeping KPassivePopup as fallback in case the D-Bus invocation fails.
> The invocation code is a heavily simplified version of dimsuz's code
> in NotifyByPopup of KNotify, therefore his copyright instead of mine.

[about 50 lines of code removed]

+ KNotification::event( "kdialogPassivePopup", text );

 Or something like that. Plus the small .eventsrc file. I think it will never 
cease to amaze to me how great lengths some people can go instead of doing 
things simply. Not to count the code duplication or smaller flexibility.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz
[prev in list] [next in list] [prev in thread] [next in thread]