[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/context/applets/currenttrack
From:       "Seb Ruiz" <ruiz () kde ! org>
Date:       2009-01-09 13:06:56
Message-ID: 60ebdd0b0901090506w12a05a2cgbd83219d75f8347 () mail ! gmail ! com
[Download RAW message or body]

2009/1/9 Mark Kretschmann <kretschmann@kde.org>:
> On Thu, Jan 8, 2009 at 8:05 PM, Dan Meltzer
> <parallelgrapefruit@gmail.com> wrote:
>> On Thu, Jan 8, 2009 at 1:50 PM, Mark Kretschmann <kretschmann@kde.org> wrote:
>>> SVN commit 907803 by markey:
>>>
>>> Don't show the rating widget for tracks which are not in the collection.
>>
>> inCollection() returns true if the track is in _any_ collection... so
>> this fix is not all that accurate, the rating will be shown for
>> ampache (and other) tracks still.
>>
>> Either we should check for the statistics capability (which Seb added,
>> if I recall) [...]
>
> This sounds like a good idea, but the mythical Statistics Capability
> doesn't seem to exist in trunk.

It's called ImportCapability - let's just rename it to StatisticsCapability.

>
> --
> Mark Kretschmann
> Amarok Developer
> www.kde.org - amarok.kde.org
>



-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]