From kde-commits Fri Jan 09 13:06:56 2009 From: "Seb Ruiz" Date: Fri, 09 Jan 2009 13:06:56 +0000 To: kde-commits Subject: Re: extragear/multimedia/amarok/src/context/applets/currenttrack Message-Id: <60ebdd0b0901090506w12a05a2cgbd83219d75f8347 () mail ! gmail ! com> X-MARC-Message: https://marc.info/?l=kde-commits&m=123150647602288 2009/1/9 Mark Kretschmann : > On Thu, Jan 8, 2009 at 8:05 PM, Dan Meltzer > wrote: >> On Thu, Jan 8, 2009 at 1:50 PM, Mark Kretschmann wrote: >>> SVN commit 907803 by markey: >>> >>> Don't show the rating widget for tracks which are not in the collection. >> >> inCollection() returns true if the track is in _any_ collection... so >> this fix is not all that accurate, the rating will be shown for >> ampache (and other) tracks still. >> >> Either we should check for the statistics capability (which Seb added, >> if I recall) [...] > > This sounds like a good idea, but the mythical Statistics Capability > doesn't seem to exist in trunk. It's called ImportCapability - let's just rename it to StatisticsCapability. > > -- > Mark Kretschmann > Amarok Developer > www.kde.org - amarok.kde.org > -- Seb Ruiz http://www.sebruiz.net/ http://amarok.kde.org/