[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdebase/apps/dolphin/src
From:       Peter Penz <peter.penz () gmx ! at>
Date:       2008-12-21 15:46:52
Message-ID: 200812211646.52525.peter.penz () gmx ! at
[Download RAW message or body]

Ah, sorry Rafael - the patch is completely bogus. I don't know why it seems to 
work at all.

I'll check this in detail again if I have more time :-)

On Sunday, 21. December 2008 16:42:30 Peter Penz wrote:
> Hi Rafael,
>
> Thanks for the detailed explanation.
>
> On Sunday, 21. December 2008 12:25:50 Rafael Fernández López wrote:
> > Hi,
> >
> > Maybe a further explanation is even better...
> >
> > I agree there is a problem though... the categorized view placing those
> > elements at the end because of the "Others" context while not categorized
> > shows them at the beginning.
> >
> > For me "Others" should be clearly at the end, because its context doesn't
> > let it being at the top "Others, what others ? I haven't still seen any
> > categories !", not on the middle "Others, what others ? I haven't still
> > seen all categories !", but on the bottom, where you have already seen
> > and discarded all categories.
>
> I agree with you that "Others" should stay always at the end when using
> categorization.
>
> > OTOH I agree too that moving those elements to the end on the non
> > categorized view is strange. Having elements starting by A.... by Z and
> > then those that start with numbers, however, is a chance.
> >
> > So, to wrap up, please Peter do whatever you feel is more convenient. :)
>
> The problem described in bug 173027 was that the elements _within_ the
> others group are not sorted anymore. I've attached a new patch which
> assures: - that the "Others" group stays the last group of the
> categorization as before - that the elements within the "Others" group will
> get sorted
>
> Is the patch OK from your point of view?
>
> I just wrote this patch in a few minutes and was confused why QChar('z')
> works while Char(123) (ASCII code from 'z' is 122) does not work (the
> "Others" group will be inserted in between then) -> I'll check the reason
> when I have a little bit more time. Anyhow the approach of adding a postfix
> to the string should solve the issue.
>
> Best regards,
> Peter
>
> > Regards and thanks !
> > Rafael Fernández López.


[prev in list] [next in list] [prev in thread] [next in thread]