[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevelop/plugins
From:       Laurent Montel <montel () kde ! org>
Date:       2008-11-28 8:04:31
Message-ID: 1227859471.293842.15250.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 889975 by mlaurent:

Const'ify


 M  +1 -1      builders/makebuilder/makejob.cpp  
 M  +2 -2      documentview/kdevdocumentview.cpp  
 M  +6 -6      managers/custommake/custommaketreesynchronizer.cpp  
 M  +16 -16    managers/qmake/qmakeprojectfile.cpp  


--- trunk/KDE/kdevelop/plugins/builders/makebuilder/makejob.cpp #889974:889975
@@ -115,7 +115,7 @@
     connect( m_process, SIGNAL( finished( int, QProcess::ExitStatus ) ),
              this, SLOT( procFinished( int, QProcess::ExitStatus ) ) );
 
-    Q_FOREACH( QString s, environmentVars().keys() )
+    Q_FOREACH( const QString& s, environmentVars().keys() )
     {
         m_process->setEnv( s, environmentVars()[s] );
     }
--- trunk/KDE/kdevelop/plugins/documentview/kdevdocumentview.cpp #889974:889975
@@ -144,7 +144,7 @@
     KDevDocumentModel *docModel = qobject_cast<KDevDocumentModel*>( model() );
 
     m_selectedDocs.clear();
-    foreach ( QModelIndex index, indexes )
+    foreach ( const QModelIndex& index, indexes )
     {
         if ( KDevFileItem * fileItem = dynamic_cast<KDevDocumentItem*>( \
docModel->itemFromIndex( index ) )->fileItem() )  {
@@ -161,7 +161,7 @@
 bool KDevDocumentView::someDocHasChanges()
 {
     KDevelop::IDocumentController* dc = m_plugin->core()->documentController();
-    foreach(KUrl url, m_selectedDocs)
+    foreach(const KUrl& url, m_selectedDocs)
     {
         KDevelop::IDocument* doc = dc->documentForUrl(url);
         if (!doc) continue;
--- trunk/KDE/kdevelop/plugins/managers/custommake/custommaketreesynchronizer.cpp \
#889974:889975 @@ -67,15 +67,15 @@
 void CustomMakeTreeSynchronizer::filesCreated( const KUrl::List &files,
                                                KDevelop::ProjectFolderItem \
*parentFolder )  {
-    Q_FOREACH( KUrl _file, files )
+    Q_FOREACH( const KUrl& _file, files )
     {
         KDevelop::ProjectFileItem *newitem = new KDevelop::ProjectFileItem(
             parentFolder->project(), _file, parentFolder );
         // if Makefile, parse new targets and add to watcher
         if( _file.fileName() == QString( "Makefile" ) ) // TODO portable, setting \
aware  {
-            QStringList newTargets = m_customMan->parseCustomMakeFile( _file );
-            Q_FOREACH( QString newTarget, newTargets )
+            const QStringList newTargets = m_customMan->parseCustomMakeFile( _file \
); +            Q_FOREACH( const QString& newTarget, newTargets )
             {
                 new CustomMakeTargetItem( parentFolder->project(), newTarget, \
parentFolder );  }
@@ -97,7 +97,7 @@
 void CustomMakeTreeSynchronizer::directoriesCreated( const KUrl::List &files,
                                         KDevelop::ProjectFolderItem *parentFolder )
 {
-    Q_FOREACH( KUrl _file, files )
+    Q_FOREACH( const KUrl& _file, files )
     {
         KDevelop::ProjectBuildFolderItem *newitem = new \
KDevelop::ProjectBuildFolderItem(  parentFolder->project(), _file, parentFolder );
@@ -175,8 +175,8 @@
     else
     {
         // Makefile contents modified
-        QStringList newTargets = m_customMan->parseCustomMakeFile( KUrl(file) );
-        Q_FOREACH( QString newTarget, newTargets )
+        const QStringList newTargets = m_customMan->parseCustomMakeFile( KUrl(file) \
); +        Q_FOREACH( const QString& newTarget, newTargets )
         {
             new CustomMakeTargetItem( project, newTarget, parentFolder );
         }
--- trunk/KDE/kdevelop/plugins/managers/qmake/qmakeprojectfile.cpp #889974:889975
@@ -53,13 +53,13 @@
 
 bool QMakeProjectFile::read()
 {
-    foreach( QString var, m_mkspecs->variables() )
+    foreach( const QString& var, m_mkspecs->variables() )
     {
         m_variableValues[var] = m_mkspecs->variableValues( var );
     }
     if( m_cache )
     {
-        foreach( QString var, m_cache->variables() )
+        foreach( const QString& var, m_cache->variables() )
         {
             m_variableValues[var] = m_cache->variableValues( var );
         }
@@ -71,7 +71,7 @@
 {
     kDebug(9024) << "Fetching subprojects";
     QList<QMakeProjectFile*> list;
-    foreach( QString subdir, variableValues( "SUBDIRS" ) )
+    foreach(  QString subdir, variableValues( "SUBDIRS" ) )
     {
         QString fileOrPath;
         kDebug(9024) << "Found value:" << subdir;
@@ -126,14 +126,14 @@
 
     KUrl::List list;
     kDebug(9024) << variableValues("INCLUDEPATH");
-    foreach( QString val, variableValues("INCLUDEPATH") )
+    foreach( const QString& val, variableValues("INCLUDEPATH") )
     {
         KUrl url(val);
         if( !list.contains( url ) )
             list << url;
     }
     kDebug(9024) << variableValues("QMAKE_INCDIR");
-    foreach( QString val, variableValues("QMAKE_INCDIR") )
+    foreach( const QString& val, variableValues("QMAKE_INCDIR") )
     {
         KUrl url(val);
         if( !list.contains( url ) )
@@ -142,7 +142,7 @@
     kDebug(9024) << variableValues("QMAKE_INCDIR_OPENGL");
     if( variableValues("CONFIG").contains("opengl") )
     {
-        foreach( QString val, variableValues("QMAKE_INCDIR_OPENGL") )
+        foreach( const QString& val, variableValues("QMAKE_INCDIR_OPENGL") )
         {
             KUrl url(val);
             if( !list.contains( url ) )
@@ -154,7 +154,7 @@
     {
         //@TODO add QtCore,QtGui and so on depending on CONFIG values,
         //      as QMAKE_INCDIR_QT only contains the include/ dir
-        foreach( QString val, variableValues("QMAKE_INCDIR_QT") )
+        foreach( const QString& val, variableValues("QMAKE_INCDIR_QT") )
         {
             KUrl url(val);
             if( !list.contains( url ) )
@@ -164,7 +164,7 @@
     kDebug(9024) << variableValues("QMAKE_INCDIR_THREAD");
     if( variableValues("CONFIG").contains("thread") )
     {
-        foreach( QString val, variableValues("QMAKE_INCDIR_THREAD") )
+        foreach( const QString& val, variableValues("QMAKE_INCDIR_THREAD") )
         {
             KUrl url(val);
             if( !list.contains( url ) )
@@ -174,7 +174,7 @@
     kDebug(9024) << variableValues("QMAKE_INCDIR_X11");
     if( variableValues("CONFIG").contains("x11") )
     {
-        foreach( QString val, variableValues("QMAKE_INCDIR_X11") )
+        foreach( const QString& val, variableValues("QMAKE_INCDIR_X11") )
         {
             KUrl url(val);
             if( !list.contains( url ) )
@@ -190,9 +190,9 @@
 
 
     KUrl::List list;
-    foreach( QString variable, QMakeProjectFile::FileVariables )
+    foreach( const QString& variable, QMakeProjectFile::FileVariables )
     {
-        foreach( QString value, variableValues(variable) )
+        foreach( const QString& value, variableValues(variable) )
         {
             list += KUrl::List( resolveFileName( value ) );
         }
@@ -209,10 +209,10 @@
     KUrl::List list;
     if( variableValues("INSTALLS").contains(s) )
     {
-        QStringList files = variableValues(s+".files");
+        const QStringList files = variableValues(s+".files");
         if( !files.isEmpty() )
         {
-            foreach( QString val, files )
+            foreach( const QString& val, files )
             {
                 list += KUrl::List( resolveFileName( val ) );
             }
@@ -220,9 +220,9 @@
     }
     if( !variableValues("INSTALLS").contains(s) || s == "target" )
     {
-        foreach( QString variable, QMakeProjectFile::FileVariables )
+        foreach( const QString& variable, QMakeProjectFile::FileVariables )
         {
-            foreach( QString value, variableValues(variable) )
+            foreach( const QString& value, variableValues(variable) )
             {
                 list += KUrl::List( resolveFileName( value ) );
             }
@@ -254,7 +254,7 @@
         list += QFileInfo( absoluteFile() ).baseName();
     }
 
-    foreach( QString target, variableValues("INSTALLS") )
+    foreach( const QString& target, variableValues("INSTALLS") )
     {
         if( target != "target" )
             list << target;


[prev in list] [next in list] [prev in thread] [next in thread]