[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevelop/plugins
From:       Laurent Montel <montel () kde ! org>
Date:       2008-11-28 7:55:44
Message-ID: 1227858944.409297.14997.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 889972 by mlaurent:

const'ify


 M  +1 -1      coverage/covoutputmodel.cpp  
 M  +3 -3      languages/cpp/cpplanguagesupport.cpp  
 M  +3 -3      managers/automake/makefileinterface.cpp  
 M  +1 -1      managers/custommake/projectfilesystemwatcher.cpp  


--- trunk/KDE/kdevelop/plugins/coverage/covoutputmodel.cpp #889971:889972
@@ -67,7 +67,7 @@
 
 void CovOutputModel::appendErrors(const QStringList &lines)
 {
-    foreach(QString line, lines) {
+    foreach(const QString& line, lines) {
         appendRow(new QStandardItem(line));
     }
 }
--- trunk/KDE/kdevelop/plugins/languages/cpp/cpplanguagesupport.cpp #889971:889972
@@ -674,7 +674,7 @@
     }
 
     //Insert the standard-paths at the end
-    foreach( QString path, *m_standardIncludePaths) {
+    foreach( const QString& path, *m_standardIncludePaths) {
       KUrl u(path);
       if(!hasPath.contains(u))
         allPaths << KUrl(path);
@@ -758,7 +758,7 @@
     bool needSkip = !skipPath.isEmpty();
 
 restart:
-    foreach( KUrl path, includePaths ) {
+    foreach( const KUrl& path, includePaths ) {
         if( needSkip ) {
             if( path == skipPath ) {
                 needSkip = false;
@@ -784,7 +784,7 @@
 
     if( ret.first.isEmpty() && !quiet ) {
         kDebug(9007) << "FAILED to find include-file" << includeName << "in paths:";
-        foreach( KUrl path, includePaths )
+        foreach( const KUrl& path, includePaths )
             kDebug(9007) << path;
     }
 
--- trunk/KDE/kdevelop/plugins/managers/automake/makefileinterface.cpp #889971:889972
@@ -170,7 +170,7 @@
 
 
     QStringList subdirs = subdirsFor( dir );
-    foreach( QString sd, subdirs )
+    foreach( const QString& sd, subdirs )
     {
         kDebug(9020) << "Beginning parsing of '" << sd << "'";
         parse( dir.path() + '/' + sd, recursive );
@@ -284,7 +284,7 @@
             AssignmentAST* assignment = static_cast<AssignmentAST*>( (*cit) );
             if (  assignment->scopedID.contains( AutoMake::targetPrimaries ) )
             {
-                foreach( QString target, assignment->values )
+                foreach( const QString& target, assignment->values )
                 {
                     if ( target == "#" || target == "\\"  )
                         continue;
@@ -410,7 +410,7 @@
 
 
     QStringList valuesList = valuesForId( targetId, ast );
-    foreach( QString value, valuesList )
+    foreach( const QString& value, valuesList )
     {
         if ( value == QLatin1String( "\\" ) )
             continue;
--- trunk/KDE/kdevelop/plugins/managers/custommake/projectfilesystemwatcher.cpp #889971:889972
@@ -70,7 +70,7 @@
     // emitted first, and signal for child directories are emitted at next, which results in crash.
     // So, when removing a directory, remove all of its children files and directories
         QList<QString> dirkeys = d->m_folderHash.keys();
-        Q_FOREACH( QString _key, dirkeys )
+        Q_FOREACH( const QString& _key, dirkeys )
         {
             if( _key.contains(path) )
             {
[prev in list] [next in list] [prev in thread] [next in thread]