[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/apps
From:       Albert Astals Cid <tsdgeos () terra ! es>
Date:       2008-09-20 11:51:30
Message-ID: 1221911490.456645.24254.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 862919 by aacid:

constify to detach less


 M  +2 -2      konqueror/settings/kio/useragentdlg.cpp  
 M  +2 -2      konqueror/sidebar/trees/bookmark_module/bookmark_module.cpp  
 M  +10 -10    konqueror/src/konqmainwindow.cpp  
 M  +3 -3      konqueror/src/konqviewmanager.cpp  
 M  +2 -2      lib/konq/konq_operations.cpp  


--- trunk/KDE/kdebase/apps/konqueror/settings/kio/useragentdlg.cpp #862918:862919
@@ -255,11 +255,11 @@
   if (!m_userAgentInfo)
     m_userAgentInfo = new UserAgentInfo();
 
-  QStringList list = m_config->groupList();
+  const QStringList list = m_config->groupList();
   QStringList::ConstIterator endIt = list.end();
   QString agentStr;
 
-  for ( QStringList::Iterator it = list.begin(); it != endIt; ++it )
+  for ( QStringList::ConstIterator it = list.begin(); it != endIt; ++it )
   {
     if ( (*it) == "<default>")
         continue;
--- trunk/KDE/kdebase/apps/konqueror/sidebar/trees/bookmark_module/bookmark_module.cpp \
#862918:862919 @@ -288,10 +288,10 @@
         parentGroup = s_bookmarkManager->root();
     }
 
-    KBookmark::List bookmarks = KBookmark::List::fromMimeData(e->mimeData());
+    const KBookmark::List bookmarks = KBookmark::List::fromMimeData(e->mimeData());
 
     // copy
-    KBookmark::List::iterator it = bookmarks.begin();
+    KBookmark::List::const_iterator it = bookmarks.begin();
     for (;it != bookmarks.end(); ++it) {
         // insert new item.
         parentGroup.moveItem(*it, afterBookmark);
--- trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp #862918:862919
@@ -1339,10 +1339,10 @@
 
 void KonqMainWindow::slotSendURL()
 {
-  KUrl::List lst = currentURLs();
+  const KUrl::List lst = currentURLs();
   QString body;
   QString fileNameList;
-  for ( KUrl::List::Iterator it = lst.begin() ; it != lst.end() ; ++it )
+  for ( KUrl::List::ConstIterator it = lst.begin() ; it != lst.end() ; ++it )
   {
     if ( !body.isEmpty() ) body += '\n';
     body += (*it).prettyUrl();
@@ -1360,10 +1360,10 @@
 
 void KonqMainWindow::slotSendFile()
 {
-  KUrl::List lst = currentURLs();
+  const KUrl::List lst = currentURLs();
   QStringList urls;
   QString fileNameList;
-  for ( KUrl::List::Iterator it = lst.begin() ; it != lst.end() ; ++it )
+  for ( KUrl::List::ConstIterator it = lst.begin() ; it != lst.end() ; ++it )
   {
     if ( !fileNameList.isEmpty() ) fileNameList += ", ";
     if ( (*it).isLocalFile() && QFileInfo((*it).path()).isDir() )
@@ -4222,9 +4222,9 @@
     //kDebug(1202) << enable;
   KParts::BrowserExtension::ActionSlotMap * actionSlotMap = \
KParts::BrowserExtension::actionSlotMapPtr();  
-  QList<QAction *> actions = actionCollection()->actions();
-  QList<QAction *>::Iterator it = actions.begin();
-  QList<QAction *>::Iterator end = actions.end();
+  const QList<QAction *> actions = actionCollection()->actions();
+  QList<QAction *>::ConstIterator it = actions.begin();
+  QList<QAction *>::ConstIterator end = actions.end();
   for (; it != end; ++it )
   {
     QAction *act = *it;
@@ -4417,7 +4417,7 @@
   req.openAfterCurrentPage = false;
   req.forceAutoEmbed = true;
 
-  QList<KUrl> list = grp.groupUrlList();
+  const QList<KUrl> list = grp.groupUrlList();
   if (list.isEmpty())
     return;
 
@@ -4429,8 +4429,8 @@
       return;
   }
 
-  QList<KUrl>::Iterator it = list.begin();
-  QList<KUrl>::Iterator end = list.end();
+  QList<KUrl>::ConstIterator it = list.begin();
+  QList<KUrl>::ConstIterator end = list.end();
   --end;
   for (; it != end; ++it )
   {
--- trunk/KDE/kdebase/apps/konqueror/src/konqviewmanager.cpp #862918:862919
@@ -624,9 +624,9 @@
   bool bShowActiveViewIndicator = ( m_pMainWindow->viewCount() > 1 );
   bool bShowLinkedViewIndicator = ( m_pMainWindow->linkableViewsCount() > 1 );
 
-  KonqMainWindow::MapViews mapViews = m_pMainWindow->viewMap();
-  KonqMainWindow::MapViews::Iterator it = mapViews.begin();
-  KonqMainWindow::MapViews::Iterator end = mapViews.end();
+  const KonqMainWindow::MapViews mapViews = m_pMainWindow->viewMap();
+  KonqMainWindow::MapViews::ConstIterator it = mapViews.begin();
+  KonqMainWindow::MapViews::ConstIterator end = mapViews.end();
   for (  ; it != end ; ++it )
   {
     KonqFrameStatusBar* sb = it.value()->frame()->statusbar();
--- trunk/KDE/kdebase/apps/lib/konq/konq_operations.cpp #862918:862919
@@ -415,8 +415,8 @@
         Q_ASSERT ( access( QFile::encodeName(m_destUrl.path()), X_OK ) == 0 );
         // Launch executable for each of the files
         QStringList args;
-        KUrl::List lst = m_info->urls;
-        KUrl::List::Iterator it = lst.begin();
+        const KUrl::List lst = m_info->urls;
+        KUrl::List::ConstIterator it = lst.begin();
         for ( ; it != lst.end() ; it++ )
             args << (*it).path(); // assume local files
         kDebug(1203) << "starting " << m_destUrl.path() << " with " << lst.count() \
<< " arguments";


[prev in list] [next in list] [prev in thread] [next in thread]