[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/apps
From:       Laurent Montel <montel () kde ! org>
Date:       2008-09-18 11:24:48
Message-ID: 1221737088.319404.18552.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 862272 by mlaurent:

Const'ify when possible


 M  +1 -1      kappfinder/common.cpp  
 M  +1 -1      kappfinder/main_install.cpp  
 M  +2 -2      kappfinder/toplevel.cpp  
 M  +2 -2      kdepasswd/kcm/chfacedlg.cpp  
 M  +1 -1      keditbookmarks/commands.cpp  
 M  +1 -1      keditbookmarks/importers.cpp  
 M  +1 -1      keditbookmarks/toplevel.cpp  
 M  +2 -2      kfind/kfinddlg.cpp  
 M  +3 -3      kfind/kquery.cpp  
 M  +3 -3      kinfocenter/usbview/usbdevices.cpp  
 M  +2 -2      konqueror/remoteencodingplugin/kremoteencodingplugin.cpp  
 M  +3 -3      konqueror/settings/kio/kcookiesmanagement.cpp  
 M  +1 -1      konqueror/settings/konq/previews.cpp  
 M  +1 -1      konqueror/settings/konqhtml/appearance.cpp  
 M  +4 -4      konqueror/sidebar/sidebar_widget.cpp  
 M  +1 -1      konqueror/sidebar/trees/bookmark_module/bookmark_module.cpp  
 M  +1 -1      konqueror/sidebar/trees/history_module/history_module.cpp  
 M  +1 -1      konqueror/sidebar/web_module/web_module.cpp  
 M  +1 -1      konqueror/src/konqviewmanager.cpp  
 M  +1 -1      lib/konq/knewmenu.cpp  
 M  +1 -1      nsplugins/plugin_part.cpp  
 M  +1 -1      nsplugins/plugin_paths.cpp  


--- trunk/KDE/kdebase/apps/kappfinder/common.cpp #862271:862272
@@ -143,7 +143,7 @@
 
   QStringList dirs = KGlobal::dirs()->findAllResources( "data", \
"kappfinder/apps/*.directory", KStandardDirs::Recursive );  
-  QStringList::Iterator it;
+  QStringList::const_iterator it;
   for ( it = dirs.begin(); it != dirs.end(); ++it ) {
     // find out the name of the file to store
     QString destName = *it;
--- trunk/KDE/kdebase/apps/kappfinder/main_install.cpp #862271:862272
@@ -48,7 +48,7 @@
 
   QList<AppLnkCache*> appCache;
 
-  QStringList::Iterator it;
+  QStringList::const_iterator it;
   for ( it = templates.begin(); it != templates.end(); ++it )
     scanDesktopFile( appCache, *it, dir );
 
--- trunk/KDE/kdebase/apps/kappfinder/toplevel.cpp #862271:862272
@@ -169,7 +169,7 @@
 
   mListView->clear();
 
-  QStringList::Iterator it;
+  QStringList::const_iterator it;
   for ( it = mTemplates.begin(); it != mTemplates.end(); ++it ) {
     // eye candy
     mProgress->setValue( mProgress->value() + 1 );
@@ -207,7 +207,7 @@
       QTreeWidgetItem *dirItem = 0;
       QString tmpRelPath = QString();
 
-      QStringList::Iterator tmpIt;
+      QStringList::const_iterator tmpIt;
       for ( tmpIt = dirList.begin(); tmpIt != dirList.end(); ++tmpIt ) {
         dirItem = addGroupItem( dirItem, tmpRelPath, *tmpIt );
         tmpRelPath += *tmpIt + '/';
--- trunk/KDE/kdebase/apps/kdepasswd/kcm/chfacedlg.cpp #862271:862272
@@ -81,14 +81,14 @@
   if ( facesDir.exists() )
   {
     QStringList picslist = facesDir.entryList( QDir::Files );
-    for ( QStringList::Iterator it = picslist.begin(); it != picslist.end(); ++it )
+    for ( QStringList::const_iterator it = picslist.begin(); it != picslist.end(); \
                ++it )
       new QListWidgetItem( QIcon( picsdir + *it ), (*it).section(".",0,0), \
ui.m_FacesWidget );  }
   facesDir.setPath( KCFGUserAccount::userFaceDir() );
   if ( facesDir.exists() )
   {
     QStringList picslist = facesDir.entryList( QDir::Files );
-    for ( QStringList::Iterator it = picslist.begin(); it != picslist.end(); ++it )
+    for ( QStringList::const_iterator it = picslist.begin(); it != picslist.end(); \
++it )  new QListWidgetItem( QIcon( KCFGUserAccount::userFaceDir() + *it ),
                            '/'+(*it) == KCFGUserAccount::customFaceFile() ? 
                            i18n("(Custom)") : (*it).section(".",0,0),
--- trunk/KDE/kdebase/apps/keditbookmarks/commands.cpp #862271:862272
@@ -408,7 +408,7 @@
     for (KBookmark bk = parentGroup.first();
             !bk.isNull(); bk = parentGroup.next(bk))
         lstToDelete.prepend(bk.address());
-    for (QStringList::Iterator it = lstToDelete.begin();
+    for (QStringList::const_iterator it = lstToDelete.begin();
             it != lstToDelete.end(); ++it)
         cmd->addCommand(new DeleteCommand((*it)));
     return cmd;
--- trunk/KDE/kdebase/apps/keditbookmarks/importers.cpp #862271:862272
@@ -266,7 +266,7 @@
         QStringList tags;
         for (int i = 0; i < subDoc.attributes().count(); i++)
             tags << subDoc.attributes().item(i).toAttr().name();
-        for (QStringList::Iterator it = tags.begin(); it != tags.end(); ++it)
+        for (QStringList::const_iterator it = tags.begin(); it != tags.end(); ++it)
             subDoc.attributes().removeNamedItem((*it));
 
         subDoc.toElement().setAttribute("icon", m_icon);
--- trunk/KDE/kdebase/apps/keditbookmarks/toplevel.cpp #862271:862272
@@ -419,7 +419,7 @@
         }
     }
 
-    for ( QStringList::Iterator it = toEnable.begin();
+    for ( QStringList::const_iterator it = toEnable.begin();
             it != toEnable.end(); ++it )
     {
         //kDebug() <<" enabling action "<<(*it);
--- trunk/KDE/kdebase/apps/kfind/kfinddlg.cpp #862271:862272
@@ -143,7 +143,7 @@
   if(tabWidget->isSearchRecursive() && (dirwatch->internalMethod() == \
KDirWatch::FAM))  {
     QStringList subdirs=getAllSubdirs(query->url().path());
-    for(QStringList::Iterator it = subdirs.begin(); it != subdirs.end(); ++it)
+    for(QStringList::const_iterator it = subdirs.begin(); it != subdirs.end(); ++it)
       dirwatch->addDir(*it,true);
   }
 #endif
@@ -284,7 +284,7 @@
   d.setFilter( QDir::Dirs );
   dirs = d.entryList();
 
-  for(QStringList::Iterator it = dirs.begin(); it != dirs.end(); ++it)
+  for(QStringList::const_iterator it = dirs.begin(); it != dirs.end(); ++it)
   {
     if((*it==".")||(*it==".."))
       continue;
--- trunk/KDE/kdebase/apps/kfind/kquery.cpp #862271:862272
@@ -155,8 +155,8 @@
   metaKeyRx=new QRegExp(m_metainfokey);
   metaKeyRx->setPatternSyntax( QRegExp::Wildcard );
 
-  QStringList::Iterator it = list.begin();
-  QStringList::Iterator end = list.end();
+  QStringList::const_iterator it = list.begin();
+  QStringList::const_iterator end = list.end();
 
   for (; it != end; ++it)
   {
@@ -268,7 +268,7 @@
        QString strmetakeycontent;
 
        metakeys = metadatas.supportedKeys();
-       for (QStringList::Iterator it = metakeys.begin(); it != metakeys.end(); ++it \
) +       for (QStringList::const_iterator it = metakeys.begin(); it != \
metakeys.end(); ++it )  {
           if (!metaKeyRx->exactMatch(*it))
              continue;
--- trunk/KDE/kdebase/apps/kinfocenter/usbview/usbdevices.cpp #862271:862272
@@ -98,7 +98,7 @@
 	dir.setFilter(QDir::Dirs);
 	QStringList list = dir.entryList();
 
-	for (QStringList::Iterator it = list.begin(); it != list.end(); ++it) {
+	for (QStringList::const_iterator it = list.begin(); it != list.end(); ++it) {
 		if ((*it).contains(':'))
 			continue;
 
@@ -206,7 +206,7 @@
 	r += i18n("<tr><td><i>Power Consumption</i></td><td>self powered</td></tr>");
 	r += i18n("<tr><td><i>Attached Devicenodes</i></td><td>%1</td></tr>", \
_devnodes.at(0));  if ( _devnodes.count() > 1 ) {
-		QStringList::Iterator it = _devnodes.begin();
+		QStringList::const_iterator it = _devnodes.begin();
 		++it;
 		for (; it != _devnodes.end(); ++it )
 		r += "<tr><td></td><td>" + *it + "</td></tr>";
@@ -276,7 +276,7 @@
 	d.setNameFilters(QStringList() << "usb*");
 	QStringList list = d.entryList();
 
-	for (QStringList::Iterator it = list.begin(); it != list.end(); ++it) {
+	for (QStringList::const_iterator it = list.begin(); it != list.end(); ++it) {
 		USBDevice* device = new USBDevice();
 
 		int bus = 0;
--- trunk/KDE/kdebase/apps/konqueror/remoteencodingplugin/kremoteencodingplugin.cpp \
#862271:862272 @@ -144,7 +144,7 @@
   if (!charset.isEmpty())
     {
       int id = 1;
-      QStringList::Iterator it;
+      QStringList::const_iterator it;
       for (it = m_encodingDescriptions.begin(); it != m_encodingDescriptions.end(); \
++it, ++id)  if ((*it).indexOf(charset) != -1)
 	  break;
@@ -213,7 +213,7 @@
 	  partList.erase(partList.begin());
 	}
 
-      for (QStringList::Iterator it = domains.begin(); it != domains.end();
+      for (QStringList::const_iterator it = domains.begin(); it != domains.end();
 	   ++it)
 	{
 	  kDebug() << "Domain to remove: " << *it;
--- trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiesmanagement.cpp \
#862271:862272 @@ -269,7 +269,7 @@
   }
 
   CookieListViewItem *dom;
-  for(QStringList::Iterator dIt = domains.begin(); dIt != domains.end(); dIt++)
+  for(QStringList::const_iterator dIt = domains.begin(); dIt != domains.end(); \
dIt++)  {
     dom = new CookieListViewItem(dlg->lvCookies, *dIt);
     dom->setChildIndicatorPolicy(QTreeWidgetItem::ShowIndicator);
@@ -302,7 +302,7 @@
   if(reply.isValid())
   {
     QStringList fieldVal = reply;
-    QStringList::Iterator fIt = fieldVal.begin();
+    QStringList::const_iterator fIt = fieldVal.begin();
 
     while(fIt != fieldVal.end())
     {
@@ -336,7 +336,7 @@
 
   QStringList fieldVal = reply;
 
-  QStringList::Iterator c = fieldVal.begin();
+  QStringList::const_iterator c = fieldVal.begin();
   if (c == fieldVal.end()) // empty list, do not crash
     return false;
   cookie->value = *c++;
--- trunk/KDE/kdebase/apps/konqueror/settings/konq/previews.cpp #862271:862272
@@ -94,7 +94,7 @@
 
     QStringList protocolList = KProtocolInfo::protocols();
     protocolList.sort();
-    QStringList::Iterator it = protocolList.begin();
+    QStringList::const_iterator it = protocolList.begin();
 
     KUrl url;
     url.setPath("/");
--- trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/appearance.cpp #862271:862272
@@ -338,7 +338,7 @@
     }
 
     int i = 0;
-    for ( QStringList::Iterator it = encodings.begin(); it != encodings.end(); ++it, \
++i ) +    for ( QStringList::const_iterator it = encodings.begin(); it != \
encodings.end(); ++it, ++i )  if ( encodingName == *it )
             m_pEncoding->setCurrentIndex( i );
     if(encodingName.isEmpty())
--- trunk/KDE/kdebase/apps/konqueror/sidebar/sidebar_widget.cpp #862271:862272
@@ -76,7 +76,7 @@
 	menu->clear();
 	int i = 0;
 
-	for (QStringList::Iterator it = list.begin(); it != list.end(); ++it, i++ )
+	for (QStringList::const_iterator it = list.begin(); it != list.end(); ++it, i++ )
 	{
 		KDesktopFile confFile( *it );
 		KConfigGroup desktopGroup = confFile.desktopGroup();
@@ -121,7 +121,7 @@
 		QStringList dirEntries = dir.entryList( QDir::Dirs | QDir::NoSymLinks );
 		dirEntries.removeAll(".");
 		dirEntries.removeAll("..");
-		for ( QStringList::Iterator it = dirEntries.begin(); it != dirEntries.end(); ++it \
) { +		for ( QStringList::const_iterator it = dirEntries.begin(); it != \
dirEntries.end(); ++it ) {  if ((*it)!="add")
 				 KIO::NetAccess::del(KUrl( loc+(*it) ), m_parent);
 		}
@@ -323,7 +323,7 @@
 
 	// Go through list to see which ones exist.  Check them for the URL
 	QStringList files = QDir(list).entryList("websidebarplugin*.desktop");
-	for (QStringList::Iterator it = files.begin(); it != files.end(); ++it){
+	for (QStringList::const_iterator it = files.begin(); it != files.end(); ++it){
 		KConfig _scf( list + *it, KConfig::SimpleConfig );
 		KConfigGroup scf(&_scf, "Desktop Entry");
 		if (scf.readPathEntry("URL", QString()) == url.url()) {
@@ -659,7 +659,7 @@
 		kDebug()<<"m_path: "<<m_path;
 		QDir dir(m_path);
 		QStringList list=dir.entryList("*.desktop");
-		for (QStringList::Iterator it=list.begin(); it!=list.end(); ++it)
+		for (QStringList::const_iterator it=list.begin(); it!=list.end(); ++it)
 		{
 			addButton(*it);
 		}
--- trunk/KDE/kdebase/apps/konqueror/sidebar/trees/bookmark_module/bookmark_module.cpp \
#862271:862272 @@ -538,7 +538,7 @@
     Q3ListViewItem * item = m_topLevelItem;
     // The address is something like /5/10/2
     QStringList addresses = address.split('/', QString::SkipEmptyParts);
-    for ( QStringList::Iterator it = addresses.begin() ; it != addresses.end() ; \
++it ) +    for ( QStringList::const_iterator it = addresses.begin() ; it != \
addresses.end() ; ++it )  {
         uint number = (*it).toUInt();
         item = item->firstChild();
--- trunk/KDE/kdebase/apps/konqueror/sidebar/trees/history_module/history_module.cpp \
#862271:862272 @@ -165,7 +165,7 @@
     KSharedConfig::Ptr kc = KGlobal::config();
     KConfigGroup cs( kc, "HistorySettings" );
     QStringList openGroups = cs.readEntry("OpenGroups",QStringList());
-    QStringList::Iterator it2 = openGroups.begin();
+    QStringList::const_iterator it2 = openGroups.begin();
     KonqSidebarHistoryGroupItem *group;
     while ( it2 != openGroups.end() ) {
 	group = m_dict.find( *it2 );
--- trunk/KDE/kdebase/apps/konqueror/sidebar/web_module/web_module.cpp #862271:862272
@@ -202,7 +202,7 @@
 		KUrl url;
 		url.setProtocol("file");
 		QStringList paths = KGlobal::dirs()->resourceDirs("websidebardata");
-		for (QStringList::Iterator i = paths.begin(); i != paths.end(); ++i) {
+		for (QStringList::const_iterator i = paths.begin(); i != paths.end(); ++i) {
 			if (QFileInfo(*i + "websidebar.html").exists()) {
 				url.setPath(*i + "websidebar.html");
 				break;
--- trunk/KDE/kdebase/apps/konqueror/src/konqviewmanager.cpp #862271:862272
@@ -1241,7 +1241,7 @@
     }
 
     QStringList childList = cfg.readEntry( QString::fromLatin1( "Children" \
                ).prepend( prefix ),QStringList() );
-    for ( QStringList::Iterator it = childList.begin(); it != childList.end(); ++it \
) +    for ( QStringList::const_iterator it = childList.begin(); it != \
childList.end(); ++it )  {
         loadItem( cfg, tabContainer(), *it, defaultURL, openUrl, forcedUrl );
         QWidget* currentPage = m_tabContainer->currentWidget();
--- trunk/KDE/kdebase/apps/lib/konq/knewmenu.cpp #862271:862272
@@ -383,7 +383,7 @@
     // Look into "templates" dirs.
     QStringList files = \
d->m_actionCollection->componentData().dirs()->findAllResources("templates");  \
                QMap<QString, KNewMenuSingleton::Entry> slist; // used for sorting
-    for ( QStringList::Iterator it = files.begin() ; it != files.end() ; ++it )
+    for ( QStringList::const_iterator it = files.begin() ; it != files.end() ; ++it \
)  {
         //kDebug(1203) << *it;
         if ( (*it)[0] != '.' )
--- trunk/KDE/kdebase/apps/nsplugins/plugin_part.cpp #862271:862272
@@ -222,7 +222,7 @@
     // handle arguments
     QStringList argn, argv;
 
-    QStringList::Iterator it = _args.begin();
+    QStringList::const_iterator it = _args.begin();
     for ( ; it != _args.end(); ) {
 
         int equalPos = (*it).indexOf("=");
--- trunk/KDE/kdebase/apps/nsplugins/plugin_paths.cpp #862271:862272
@@ -63,7 +63,7 @@
 
     // append environment variable NPX_PLUGIN_PATH
     QStringList envs = QString( qgetenv("NPX_PLUGIN_PATH") ).split(':');
-    QStringList::Iterator it;
+    QStringList::const_iterator it;
     for (it = envs.begin(); it != envs.end(); ++it)
         searchPaths.append(*it);
 


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic