[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice/libs/guiutils
From:       Stefan Nikolaus <stefan.nikolaus () kdemail ! net>
Date:       2008-06-01 7:18:01
Message-ID: 200806010918.04182.stefan.nikolaus () kdemail ! net
[Download RAW message or body]


On Saturday, 31. May 2008 14:30:46 Thomas Zander wrote:
> On Saturday 31. May 2008 13:54:44 Stefan Nikolaus wrote:
> > Save the painter states before and after page preparation and restore
> > them appropriately.
>
> This breaks the feature that an inheriting class can create a painter in
> the preparePage() call, I'm afraid.
> Would it be possible to go back to the boolean solution? Even if it may not
> be the most intuitive to see why it was done (maybe some comments would be
> good), it worked properly, didn't it?

No, it did not. If a painter was created in the preparation of the first page, 
the state was stored after KoPrintingDialog::preparePage(), while for the 
other pages the state was stored before. The restoring happend always before 
KoPrintingDialog::printPage() though. This led to different behaviour for the 
first page.
-- 
Regards,
Stefan

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]