--nextPart17573408.iTP6J5lnMv Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday, 31. May 2008 14:30:46 Thomas Zander wrote: > On Saturday 31. May 2008 13:54:44 Stefan Nikolaus wrote: > > Save the painter states before and after page preparation and restore > > them appropriately. > > This breaks the feature that an inheriting class can create a painter in > the preparePage() call, I'm afraid. > Would it be possible to go back to the boolean solution? Even if it may n= ot > be the most intuitive to see why it was done (maybe some comments would be > good), it worked properly, didn't it? No, it did not. If a painter was created in the preparation of the first pa= ge,=20 the state was stored after KoPrintingDialog::preparePage(), while for the=20 other pages the state was stored before. The restoring happend always befor= e=20 KoPrintingDialog::printPage() though. This led to different behaviour for t= he=20 first page. =2D-=20 Regards, Stefan --nextPart17573408.iTP6J5lnMv Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBIQk0spfDn2DABIpcRAjTVAJsE2rpuW5eaYEvy3H/4tZMi3cloywCfT84m sRlBGo3BI/zFLuuqV9gc/OI= =cg3K -----END PGP SIGNATURE----- --nextPart17573408.iTP6J5lnMv--