[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdereview/phonon/gstreamer
From:       Matthias Kretz <kretz () kde ! org>
Date:       2008-04-22 11:31:38
Message-ID: 1208863898.077814.6395.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 799800 by mkretz:

add FIXME

 M  +4 -0      devicemanager.cpp  


--- trunk/kdereview/phonon/gstreamer/devicemanager.cpp #799799:799800
@@ -127,6 +127,10 @@
     if (gst_element_set_state(element, GST_STATE_READY) == GST_STATE_CHANGE_SUCCESS)
         return true;
 
+    // FIXME: if the above failed that might only mean that some property first has to be
+    // set/changed before it will go the READY. E.g. the alsasink only probes the "default" device.
+    // If that fails for some reason it doesn't indicate a fatal error
+
     gst_element_set_state(element, GST_STATE_NULL);
     return false;
 }
[prev in list] [next in list] [prev in thread] [next in thread]