From kde-commits  Tue Apr 22 11:31:38 2008
From: Matthias Kretz <kretz () kde ! org>
Date: Tue, 22 Apr 2008 11:31:38 +0000
To: kde-commits
Subject: kdereview/phonon/gstreamer
Message-Id: <1208863898.077814.6395.nullmailer () svn ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-commits&m=120886390610762

SVN commit 799800 by mkretz:

add FIXME

 M  +4 -0      devicemanager.cpp  


--- trunk/kdereview/phonon/gstreamer/devicemanager.cpp #799799:799800
@@ -127,6 +127,10 @@
     if (gst_element_set_state(element, GST_STATE_READY) == GST_STATE_CHANGE_SUCCESS)
         return true;
 
+    // FIXME: if the above failed that might only mean that some property first has to be
+    // set/changed before it will go the READY. E.g. the alsasink only probes the "default" device.
+    // If that fails for some reason it doesn't indicate a fatal error
+
     gst_element_set_state(element, GST_STATE_NULL);
     return false;
 }