[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/akonadi/tray
From:       Frank Osterfeld <frank.osterfeld () gmx ! de>
Date:       2008-04-08 21:18:10
Message-ID: 200804082318.18750.frank.osterfeld () gmx ! de
[Download RAW message or body]


On Tuesday 08 April 2008, Tom Albers wrote:

> -    RestoreAssistant* restore = new RestoreAssistant( 0 );
> -    restore->show();
> +    RestoreAssistant restore( parentWidget() );
> +    restore.exec();
>  }

Better, but might crash due to double deletion in case the parentWidget is 
deleted while the assistant is still open. (probably prevented UI-wise, but 
dangerous if one can quit Akonadi e.g. over DBus). I suggest to use QPointer 
+ delete to be safe.

>  void Dock::updateMenu( bool registered )
> @@ -156,7 +156,7 @@
>
>  void Dock::errorMessage( const QString &message )
>  {
> -    KMessageBox::error( 0, message, i18n( "Akonadi error" ) );
> +    KMessageBox::error( parentWidget(), message, i18n( "Akonadi error" )
> ); }

<nitpicking>As it's a caption, "Akonadi Error" (capital "E").</nitpicking>

Frank

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]