--nextPart1257107.RtbWPo2k88
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 08 April 2008, Tom Albers wrote:

> -    RestoreAssistant* restore =3D new RestoreAssistant( 0 );
> -    restore->show();
> +    RestoreAssistant restore( parentWidget() );
> +    restore.exec();
>  }

Better, but might crash due to double deletion in case the parentWidget is=
=20
deleted while the assistant is still open. (probably prevented UI-wise, but=
=20
dangerous if one can quit Akonadi e.g. over DBus). I suggest to use QPointe=
r=20
+ delete to be safe.

>  void Dock::updateMenu( bool registered )
> @@ -156,7 +156,7 @@
>
>  void Dock::errorMessage( const QString &message )
>  {
> -    KMessageBox::error( 0, message, i18n( "Akonadi error" ) );
> +    KMessageBox::error( parentWidget(), message, i18n( "Akonadi error" )
> ); }

<nitpicking>As it's a caption, "Akonadi Error" (capital "E").</nitpicking>

=46rank

--nextPart1257107.RtbWPo2k88
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBH++EaFZrnbFOwfvQRAqcRAKCM0L8y7TiUSRopvgsQraCenwkylQCgg/PT
v4W7ti37GY8+GCAce2sjISo=
=R+7E
-----END PGP SIGNATURE-----

--nextPart1257107.RtbWPo2k88--