[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.0/kdelibs/kdeui/widgets
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2008-03-12 8:36:50
Message-ID: 1205311010.171062.731.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 784722 by ggarand:

automatically merged revision 783805:
People should be very careful with Qt 4's setUpdatesEnabled() as
one can end up unwillingly repainting enormous surfaces for no
good reason.

  "Re-enabling updates implicitly calls update() on the widget."

Here, the entire widget was repainted when setting the tab title,
leading to flicker and breakage of web page transitions in konqueror.

 M  +2 -2      ktabwidget.cpp  


--- branches/KDE/4.0/kdelibs/kdeui/widgets/ktabwidget.cpp #784721:784722
@@ -293,7 +293,7 @@
 
   if ( d->m_automaticResizeTabs ) {
 
-    setUpdatesEnabled(false); //no flicker
+    tabBar()->setUpdatesEnabled(false); //no flicker
 
     QTabWidget::setTabText( index, text );
 
@@ -302,7 +302,7 @@
       d->resizeTabs( index );
     }
 
-    setUpdatesEnabled(true);
+    tabBar()->setUpdatesEnabled(true);
 
   } else {
     QTabWidget::setTabText( index, text );
[prev in list] [next in list] [prev in thread] [next in thread]