[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.0/kdelibs/khtml/xml
From:       Maks Orlovich <maksim () kde ! org>
Date:       2008-01-09 8:25:52
Message-ID: 1199867152.947968.19531.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 758800 by orlovich:

Don't raise NOT_FOUND_ERROR exceptions from Element::removeAttribute...
Another bad 4.0.0 regression from 3.5.x :(
BUG:155320

 M  +3 -0      dom_elementimpl.cpp  


--- branches/KDE/4.0/kdelibs/khtml/xml/dom_elementimpl.cpp #758799:758800
@@ -518,6 +518,9 @@
     if (!id) return;
 
     attributes(false)->removeNamedItem(id, false, name.implementation(), exceptioncode);
+    // it's allowed to remove attributes that don't exist.
+    if ( exceptioncode == DOMException::NOT_FOUND_ERR )
+        exceptioncode = 0;
 }
 
 AttrImpl* ElementImpl::getAttributeNode( const DOMString &name )
[prev in list] [next in list] [prev in thread] [next in thread]