[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/4.0/kdelibs/khtml/xml
From:       Maks Orlovich <maksim () kde ! org>
Date:       2008-01-09 6:50:32
Message-ID: 1199861432.621775.17052.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 758788 by orlovich:

Fix a bad regression due to porting --- non-text key events
were using a Qt-internal key ID and not browser-semi-independent one.

KDE3.5.x used to use ->ascii() here, which would return 0
in case of special keys, making us use the m_virtKeyVal,
as appropriate. But the misused here ->key would always
return some value. So don't use it, and just use the
event text() to find out unicode IDs of normal keys..

BUG:155319

 M  +1 -1      dom2_eventsimpl.cpp  


--- branches/KDE/4.0/kdelibs/khtml/xml/dom2_eventsimpl.cpp #758787:758788
@@ -562,7 +562,7 @@
 
     //Here, we need to map Qt's internal info to browser-style info.
     m_detail = key->count();
-    m_keyVal = key->key();
+    m_keyVal = 0; // Set below unless virtual...
     m_virtKeyVal = virtKeyToQtKey()->toLeft(key->key());
 
     // m_keyVal should contain the unicode value
[prev in list] [next in list] [prev in thread] [next in thread]