[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: Re: KDE/kdepim/libkdepim
From: Allen Winter <winter () kde ! org>
Date: 2007-12-03 20:31:01
Message-ID: 200712031531.01673.winter () kde ! org
[Download RAW message or body]
On Monday 03 December 2007 12:29:27 David Faure wrote:
> On Monday 03 December 2007, Allen Winter wrote:
> >
> > -CategoryEditDialog::CategoryEditDialog( KPimPrefs *prefs, QWidget* parent )
> > +CategoryEditDialog::CategoryEditDialog( KPimPrefs *prefs, QWidget* parent,
> > + � � � � � � � � � � � � � � � � \
> > � � � � bool modal ) � � : KDialog( parent ), mPrefs( prefs )
> > � {
> > � � setCaption( i18n( "Edit Categories" ) );
> > - � setModal( true );
> > + � setModal( modal );
> > � � setButtons( Ok|Apply|Cancel|Help );
> > � � mWidgets = new Ui::CategoryEditDialog_base();
> > � � QWidget *widget = new QWidget( this );
> > --- trunk/KDE/kdepim/libkdepim/categoryeditdialog.h #744431:744432
> > @@ -40,7 +40,7 @@
> > � {
> > � � � Q_OBJECT
> > � � public:
> > - � � CategoryEditDialog( KPimPrefs *prefs, QWidget* parent = 0 );
> > + � � CategoryEditDialog( KPimPrefs *prefs, QWidget *parent = 0, bool modal \
> > = false );
>
> This is very un-Qt4.
> The Qt4 way is to call setModal (or preferrably show() or exec(), instead) from the \
> user of that dialog rather than from the dialog itself.
>
I did this to mimic the options for the CategorySelectDialog.
Guess I should have done the opposite and removed the modal option from \
CategorySelectDialog instead.
I'll try to find the time to fix the modality junk I committed.
My to-do list is very long. I really want to get KOrganizer into shape.
[Attachment #3 (text/html)]
<html><head><meta name="qrichtext" content="1" /><style type="text/css">
p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Sans Serif'; font-size:10pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">On Monday 03 \
December 2007 12:29:27 David Faure wrote:</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> On Monday 03 December 2007, Allen Winter wrote:</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> > </p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> > -CategoryEditDialog::CategoryEditDialog( KPimPrefs \
*prefs, QWidget* parent )</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > \
+CategoryEditDialog::CategoryEditDialog( KPimPrefs *prefs, QWidget* parent,</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> > + \
bool modal )</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > : KDialog( \
parent ), mPrefs( prefs )</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > \
{</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > setCaption( \
i18n( "Edit Categories" ) );</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > - \
setModal( true );</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > + setModal( modal \
);</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > setButtons( \
Ok|Apply|Cancel|Help );</p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > \
mWidgets = new Ui::CategoryEditDialog_base();</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> > QWidget *widget = new QWidget( this );</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> > --- \
trunk/KDE/kdepim/libkdepim/categoryeditdialog.h #744431:744432</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> > @@ -40,7 +40,7 @@</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> > {</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> > Q_OBJECT</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> > public:</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> > - CategoryEditDialog( KPimPrefs *prefs, QWidget* \
parent = 0 );</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;">> > + \
CategoryEditDialog( KPimPrefs *prefs, QWidget *parent = 0, bool modal = false );</p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> </p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> This is very un-Qt4.</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> The Qt4 way is to call setModal (or preferrably show() or \
exec(), instead) from the user of that dialog</p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">> rather than from the dialog itself.</p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">> </p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;"></p> <p style=" margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;">I did this to mimic the options for the CategorySelectDialog.</p> \
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">Guess I should have done the opposite and \
removed the modal option from CategorySelectDialog instead.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;">I'll try to find the time to fix the modality \
junk I committed.</p> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px;"></p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px;">My to-do list is very long. \
I really want to get KOrganizer into shape.</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;"></p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;"></p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px;"></p></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic