[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepim/libkdepim
From:       David Faure <dfaure () kdab ! net>
Date:       2007-12-03 17:29:27
Message-ID: 200712031829.28307.dfaure () kdab ! net
[Download RAW message or body]

On Monday 03 December 2007, Allen Winter wrote:
> 
> -CategoryEditDialog::CategoryEditDialog( KPimPrefs *prefs, QWidget* parent )
> +CategoryEditDialog::CategoryEditDialog( KPimPrefs *prefs, QWidget* parent,
> +                                        bool modal )
>    : KDialog( parent ), mPrefs( prefs )
>  {
>    setCaption( i18n( "Edit Categories" ) );
> -  setModal( true );
> +  setModal( modal );
>    setButtons( Ok|Apply|Cancel|Help );
>    mWidgets = new Ui::CategoryEditDialog_base();
>    QWidget *widget = new QWidget( this );
> --- trunk/KDE/kdepim/libkdepim/categoryeditdialog.h #744431:744432
> @@ -40,7 +40,7 @@
>  {
>      Q_OBJECT
>    public:
> -    CategoryEditDialog( KPimPrefs *prefs, QWidget* parent = 0 );
> +    CategoryEditDialog( KPimPrefs *prefs, QWidget *parent = 0, bool modal = false );

This is very un-Qt4.
The Qt4 way is to call setModal (or preferrably show() or exec(), instead) from the user of that dialog
rather than from the dialog itself.

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]