[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kxmlrpcclient
From:       Frank Osterfeld <frank () kdab ! net>
Date:       2007-07-20 15:43:32
Message-ID: 200707201743.32374.frank () kdab ! net
[Download RAW message or body]

On Friday 20 July 2007 16:23:00 Antonio Aloisio wrote:

> +void Client::setDateFormat( bool extended )
> +{
> +  d->mDateFormatExtended=extended;
> +}
> +
> +void Client::setTimeFormat( bool extended )
> +{
> +  d->mDateFormatExtended=extended;
> +}
> +
> +bool Client::dateFormat() const
> +{
> +  return d->mDateFormatExtended;
> +}
> +
> +bool Client::timeFormat() const
> +{
> +  return d->mTimeFormatExtended;
> +}
> +

Better rename those to something more readable and self-explaining, like 
setUseExtendedTimeFormat( bool ), bool useExtendedTimeFormat(), 
setUseExtendedDateFormat( bool )/useExtendedDateFormat(), or 
setDateFormat( DateFormat ) with enum DateFormat { BasicDateFormat, 
ExtendedDateFormat }; (TimeFormat accordingly).

-- 
Frank Osterfeld -- frank@kdab.net
Klarälvdalens Datakonsult AB, Platform-independent software solutions

[prev in list] [next in list] [prev in thread] [next in thread]