[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdepimlibs/kxmlrpcclient
From:       Allen Winter <winter () kde ! org>
Date:       2007-07-20 14:30:23
Message-ID: 200707201030.23700.winter () kde ! org
[Download RAW message or body]

On Friday 20 July 2007 10:04:04 am Frank Osterfeld wrote:
> On Friday 20 July 2007 03:36:36 Mike Arthur wrote:
> > SVN commit 690075 by mikearthur:
> >
> > Minor formatting fixes.
> >
> >
> >  M  +40 -27    query.cpp
> >
> >
> > --- trunk/KDE/kdepimlibs/kxmlrpcclient/query.cpp #690074:690075
> > @@ -140,7 +140,8 @@
> >      Result parseMessageResponse( const QDomDocument &doc ) const;
> >      Result parseFaultResponse( const QDomDocument &doc ) const;
> >
> > -    QString markupCall( const QString &method, const QList<QVariant> &args
> > ) const; 
> > +    QString markupCall( const QString &method, const QList<QVariant> 
> > &args )  
> > +        const;   
> 
> Why that?
> That's unreadable at best, and makes it easy to overlook the "const".
> 
I agree.
Mike, did you make this change because you are trying to fit lines into 80chars?

I know the kdepimlibs coding style (which copies the korganizer coding style)
says 80chars per line, but I think we should change that to 100, as per the Qt
and kdelibs coding styles.

[prev in list] [next in list] [prev in thread] [next in thread]