[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    branches/KDE/3.5/kdelibs/khtml/html
From:       Dirk Mueller <mueller () kde ! org>
Date:       2006-12-12 16:24:41
Message-ID: 1165940681.881325.3660.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 612786 by mueller:

fix crash race on various sites with popup ads, e.g. pvponline.com
(bnc:226099)


 M  +3 -2      html_objectimpl.cpp  


--- branches/KDE/3.5/kdelibs/khtml/html/html_objectimpl.cpp #612785:612786
@@ -141,8 +141,9 @@
 
 void HTMLObjectBaseElementImpl::slotRenderAlternative()
 {
-    // an unbelievable hack. FIXME!!
-    if ( m_renderAlternative ) return;
+    // the singleshot timer might have fired after we're removed
+    // from the document, but not yet deleted due to references
+    if ( !inDocument() || m_renderAlternative ) return;
 
     // ### there can be a m_render if this is called from our attach indirectly
     if ( attached() || m_render)
[prev in list] [next in list] [prev in thread] [next in thread]