From kde-commits Tue Dec 12 16:24:41 2006 From: Dirk Mueller Date: Tue, 12 Dec 2006 16:24:41 +0000 To: kde-commits Subject: branches/KDE/3.5/kdelibs/khtml/html Message-Id: <1165940681.881325.3660.nullmailer () svn ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-commits&m=116594070630247 SVN commit 612786 by mueller: fix crash race on various sites with popup ads, e.g. pvponline.com (bnc:226099) M +3 -2 html_objectimpl.cpp --- branches/KDE/3.5/kdelibs/khtml/html/html_objectimpl.cpp #612785:612786 @@ -141,8 +141,9 @@ void HTMLObjectBaseElementImpl::slotRenderAlternative() { - // an unbelievable hack. FIXME!! - if ( m_renderAlternative ) return; + // the singleshot timer might have fired after we're removed + // from the document, but not yet deleted due to references + if ( !inDocument() || m_renderAlternative ) return; // ### there can be a m_render if this is called from our attach indirectly if ( attached() || m_render)