[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    koffice/kspread
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2005-04-27 22:14:27
Message-ID: 20050427221427.78FD7630 () office ! kde ! org
[Download RAW message or body]

CVS commit by ingwa: 

Fix bug 87367: Ugly postscript rendering of cell borders.

This bug was particularly annoying since it always painted the left
border of a cell as a diagonal line across the cell.  This made cell
borders practically useless.

BUGS: 87367


  M +4 -4      TODO   1.118
  M +9 -7      kspread_cell.cc   1.712


--- koffice/kspread/TODO  #1.117:1.118
@@ -55,7 +55,5 @@
   * 77842: Strange text wrapping behavior                             1 DONE
   + 77843: Vertical text alignment problem                            1 DONE
-  + Border on a cell in the cell format dialog -> the line width      1 ----
-    does not "take".
-  + Indent and multiline doesn't work                                 2 ----
+  + Indent and multiline doesn't work together                        2 ----
 
 * Printing
@@ -67,5 +65,5 @@
   + 77962: print range doesn't work into kspread                      1 DONE
   + 85155: RIGHT ALIGN TEXT CUT WHEN PRINTING                         1 DONE?
-  + 87367: Ugly postscript rendering of cell borders.                 1 ----
+  + 87367: Ugly postscript rendering of cell borders.                 1 DONE
   + 88252: content larger than column are not print as PDF            1 DONE
   + 95159: Many blank pages when printing spreadsheet to PDF file.    1 ****
@@ -105,4 +103,6 @@
       be 100% done afterwards, if we use koscript-compat layer for functions
   + 87471: format of whole column does not change.                    1 ----
+  + Border on a cell in the cell format dialog -> the line width      1 ----
+    does not "take".
 
 * Investigate further if these are important.

--- koffice/kspread/kspread_cell.cc  #1.711:1.712
@@ -2113,5 +2113,5 @@ void KSpreadCell::paintCell( const KoRec
     selected = selected && !( markerArea.contains( cellRef ) );
 
-    // Dont draw any selection at all when printing.
+    // Don't draw any selection at all when printing.
     if ( painter.device()->isExtDev() || !drawCursor )
       selected = false;
@@ -3250,4 +3250,6 @@ void KSpreadCell::paintCellBorders( QPai
     if ( painter.device()->isExtDev() ) {
       if ( sheetDir == KSpreadSheet::RightToLeft )
+        // FIXME: There is probably Cut&Paste bugs here as well as below.  
+        //        The QMIN/QMAX and left/right pairs don't really make sense.
         painter.drawLine( QMAX( zrect_left, zcellRect_right ),
                           QMAX( zrect_top, zcellRect_top - top ),
@@ -3257,5 +3259,5 @@ void KSpreadCell::paintCellBorders( QPai
         painter.drawLine( QMAX( zrect_left, zcellRect_left ),
                           QMAX( zrect_top, zcellRect_top - top ),
-                          QMIN( zrect_right, zcellRect_right ),
+                          QMAX( zrect_left,   zcellRect_left ),
                           QMIN( zrect_bottom, zcellRect_bottom + bottom ) );
     }


[prev in list] [next in list] [prev in thread] [next in thread]