[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/kate/part
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2005-04-07 21:25:57
Message-ID: 200504072326.00767.dhdev () gmx ! de
[Download RAW message or body]


On Thursday 07 April 2005 18:51, Christoph Cullmann wrote:
> CVS commit by cullmann:
>
> security fix: use right permissions for the backup files
> if the filepermissions of the original are not accessable, why ever, use
> 0600 as fallback dominik: please test and backport
> BUG:103331
The patch looks good, and works for local files.
I tried also with a remote file via ftp, where my ftp-server only allows 
*one* session at a time. I always get an error (no matter if I activate 
passive mode or not), because of the operation

> +    // first del existing file if any, than copy over the file we have
> +    // failure if a: the existing file could not be deleted, b: the file
> +       could not be copied 
> +    if ( (!KIO::NetAccess::exists( u, false, kapp->mainWidget() ) ||
> +          KIO::NetAccess::del( u, kapp->mainWidget() )) 
> +      && KIO::NetAccess::file_copy( url(), u, perms, true, false,
> +      kapp->mainWidget() ) )
This is a *file copy*, where src and dst are the *same*. My only explanation 
is that KIO tries to authenticate two times, which always fails.

I'm no ftp expert and didn't look into the KIO code, but if this is true it 
is a (grave) KIO bug.

I'll backport anyway now, as for local files it does work.

-- 
Dominik

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]