From kde-commits  Thu Apr 07 21:25:57 2005
From: Dominik Haumann <dhdev () gmx ! de>
Date: Thu, 07 Apr 2005 21:25:57 +0000
To: kde-commits
Subject: Re: kdelibs/kate/part
Message-Id: <200504072326.00767.dhdev () gmx ! de>
X-MARC-Message: https://marc.info/?l=kde-commits&m=111294455026631
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart15253641.eBOFC1WkaA"

--nextPart15253641.eBOFC1WkaA
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Thursday 07 April 2005 18:51, Christoph Cullmann wrote:
> CVS commit by cullmann:
>
> security fix: use right permissions for the backup files
> if the filepermissions of the original are not accessable, why ever, use
> 0600 as fallback dominik: please test and backport
> BUG:103331
The patch looks good, and works for local files.
I tried also with a remote file via ftp, where my ftp-server only allows=20
*one* session at a time. I always get an error (no matter if I activate=20
passive mode or not), because of the operation

> +    // first del existing file if any, than copy over the file we have
> +    // failure if a: the existing file could not be deleted, b: the file
> +       could not be copied=20
> +    if ( (!KIO::NetAccess::exists( u, false, kapp->mainWidget() ) ||
> +          KIO::NetAccess::del( u, kapp->mainWidget() ))=20
> +      && KIO::NetAccess::file_copy( url(), u, perms, true, false,
> +      kapp->mainWidget() ) )
This is a *file copy*, where src and dst are the *same*. My only explanatio=
n=20
is that KIO tries to authenticate two times, which always fails.

I'm no ftp expert and didn't look into the KIO code, but if this is true it=
=20
is a (grave) KIO bug.

I'll backport anyway now, as for local files it does work.

=2D-=20
Dominik

--nextPart15253641.eBOFC1WkaA
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.9.15 (GNU/Linux)

iD8DBQBCVaVoKaoWlv9k7bwRAj8/AJwMp9MMq3bZotzV9sHrXGFBUQ1+bACfRt0Z
GpbRLlTJ8Xquip5eG3SMbU8=
=XTnt
-----END PGP SIGNATURE-----

--nextPart15253641.eBOFC1WkaA--