[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2005-04-07 17:24:04
Message-ID: 200504071924.05181.l.lunak () suse ! cz
[Download RAW message or body]

On Thursday 07 of April 2005 17:46, Tobias Anton wrote:
> Am Dienstag, 5. April 2005 14:21 schrieb Luboš Luňák:
> > +again:
> > +
>
> Yuck!
>
> > -                // don't return until necessary!
> >                  jsrc.decoder_timestamp.restart();
> >                  state = decompressStarted;
> > +                // don't return until necessary!
> > +                goto again;
>
> Yuck-yuck!
> Who taught you this coding style?

 Hmm. The person who taught me about state machines, whoever that was? I 
wasn't the one to write the jpeg loader, and this change in fact seemed 
cleaner then glueing in some loop.

>
> What about a
> 	"do ... while (!necessary);"
> or even a
> 	"do { ... continue; } while (false);"
> loop?

 Just curious, what benefits should this exactly bring, other than affecting 
cvs annotate for 100+ lines and making Dijkstra happy?

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
[prev in list] [next in list] [prev in thread] [next in thread]