[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdelibs/khtml
From:       Allan Sandfeld Jensen <kde () carewolf ! com>
Date:       2005-04-07 16:19:53
Message-ID: 200504071819.54096.kde () carewolf ! com
[Download RAW message or body]

On Thursday 07 April 2005 17:46, Tobias Anton wrote:
> Am Dienstag, 5. April 2005 14:21 schrieb Luboš Luňák:
> > +again:
> > +
>
> Yuck!
>
> > -                // don't return until necessary!
> >                  jsrc.decoder_timestamp.restart();
> >                  state = decompressStarted;
> > +                // don't return until necessary!
> > +                goto again;
>
> Yuck-yuck!
> Who taught you this coding style?
>
> What about a
> 	"do ... while (!necessary);"
> or even a
> 	"do { ... continue; } while (false);"
> loop?
>
Wouldn't that obfuscate it rather than make it clearer?

Repeat after me: "goto is not a necessarily a bad thing!"

`Allan
[prev in list] [next in list] [prev in thread] [next in thread]