[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] Re: kdenetwork/kopete
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2005-02-18 12:23:11
Message-ID: 200502181323.15893.ogoffart () tiscalinet ! be
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Vendredi 18 Février 2005 04:08, Jason Keirstead a écrit  :
> CVS commit by brunes:
>
> New Adium JS style. The patch I sent into the list was wrong again - it is
> simpler to just commit and if some people really hate it then revert.
>
> I encourage everyone to try and compare Adium_JS to Adium. If the new style
> suffices, we can get rid of the other Adium and use this one only.
>

> --- kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp  #1.22:1.23
> @@ -170,5 +170,5 @@ ChatMessagePart::ChatMessagePart( Kopete
>
>          //Security settings, we don't need this stuff
> -        setJScriptEnabled( false ) ;
> +        setJScriptEnabled( true ) ;


For security reason, this shouldn't be commited.

There is still many ways to inject html (and then script) in the chat window.
Protocol that may support html rich text where the html string is simply 
passed to the chatwindow.
The PGP plugin which can interpret the resulting code as html (you even did 
that yourself)

I'm against that.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]